Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove packageRules from renovatebot #5981

Merged
merged 3 commits into from
Dec 17, 2019
Merged

Remove packageRules from renovatebot #5981

merged 3 commits into from
Dec 17, 2019

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 17, 2019 •
edited
Loading

As much as I liked packageRules grouping in theory, in practice it is impractical for a few reasons:

  • We don't utilize the scheduling like we imagined and have sinse moved to the giant renovatebot issue - so everything is triggered manually. This means the grouping of 'important' packages over others in scheduling does not even matter.
  • Merging in our own packages is actually more difficult, so we end up not updating the most important packages. See the PR below, because it's trying to update 3 breaking change versions of 3 packages at once, it's more difficult to review which package broke the tests so we ignore it. fix(deps): update dependency @cypress/browserify-preprocessor to version .x 🌟 (major) - autoclosed #5396
    Screen Shot 2019-12-17 at 2 16 40 PM
  • I did end up leaving the 'types' group cause...it is a lot of deps and arguably less important to upgrade urgently, but I updated the matching to be @types/ since the previous matcher was also grabbing all PRs from @typescript
    Screen Shot 2019-12-17 at 2 50 44 PM

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 17, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@jennifer-shehane jennifer-shehane added type: chore Work is required w/ no deliverable to end user process: dependencies Related to internal dependencies labels Dec 17, 2019
@cypress
Copy link

cypress bot commented Dec 17, 2019 •
edited
Loading


Test summary

3584 • 0 • 47 • 0

Run details
Project cypress
Status Passed
Commit 7a03880
Started Dec 17, 2019 8:27 AM
Ended Dec 17, 2019 8:32 AM
Duration 05:17 💡
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

bahmutov
bahmutov approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, see what you mean with grouping

@bahmutov bahmutov merged commit 05987c4 into develop Dec 17, 2019
@emilyrohrbough emilyrohrbough deleted the remove-renovate-package-rules branch August 1, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov approved these changes

Assignees
No one assigned
Labels
process: dependencies Related to internal dependencies type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifer-shehane @bahmutov